Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A the Spot order book client (kraken.spot.OrderbookClient) #106

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented May 22, 2023

Summary

The new Spot OrderbookClient was added that enables maintaining a valid order book for Spot trading.

Changes / Features

  • Added unit tests for the new client
  • Extended and improved all unit tests regarding the Spot and Futures websocket clients
  • Add the KrakenTemporaryLockoutError that gets triggered, when the error response contains: EGeneral:Temporary lockout.
  • Extended the documentation
  • Restructured/simplified the file hierarchy
  • Increase the accuracy for Spot and Futures

@btschwertfeger btschwertfeger added enhancement New feature or request Should Something that should be implemented somewhere in the future Spot Topic related to Spot trading labels May 22, 2023
@btschwertfeger btschwertfeger self-assigned this May 22, 2023
@btschwertfeger btschwertfeger linked an issue May 22, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Attention: Patch coverage is 88.13559% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (af289f0) to head (0bdd603).
Report is 93 commits behind head on master.

Files with missing lines Patch % Lines
kraken/spot/websocket/__init__.py 60.00% 12 Missing ⚠️
kraken/spot/orderbook.py 89.77% 9 Missing ⚠️
kraken/spot/ws_client.py 92.13% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   87.04%   87.58%   +0.53%     
==========================================
  Files          17       18       +1     
  Lines        1474     1562      +88     
==========================================
+ Hits         1283     1368      +85     
- Misses        191      194       +3     
Flag Coverage Δ
unittests 87.58% <88.13%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
kraken/base_api/__init__.py 90.47% <100.00%> (-0.10%) ⬇️
kraken/exceptions/__init__.py 99.17% <100.00%> (+0.01%) ⬆️
kraken/futures/__init__.py 100.00% <100.00%> (ø)
kraken/futures/funding.py 60.86% <100.00%> (ø)
kraken/futures/market.py 91.20% <100.00%> (ø)
kraken/futures/trade.py 96.05% <100.00%> (ø)
kraken/futures/user.py 86.15% <100.00%> (ø)
kraken/futures/ws_client.py 86.58% <100.00%> (ø)
kraken/spot/__init__.py 100.00% <100.00%> (ø)
kraken/spot/funding.py 71.42% <100.00%> (ø)
... and 7 more

@btschwertfeger btschwertfeger changed the title A the Spot order book client (kraken.spot.Market.Orderbook) A the Spot order book client (kraken.spot.SpotOrderBookClient) May 25, 2023
@btschwertfeger btschwertfeger changed the title A the Spot order book client (kraken.spot.SpotOrderBookClient) A the Spot order book client (kraken.spot.OrderbookClient) May 26, 2023
@btschwertfeger btschwertfeger merged commit d5a3d7c into master Jun 10, 2023
@btschwertfeger btschwertfeger deleted the 104-add-a-spot-orderbook-client-that-handles-a-realtime-order-book branch June 10, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Should Something that should be implemented somewhere in the future Spot Topic related to Spot trading
Projects
None yet
1 participant