Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wtxmgr: ignore ErrBucketNotFound error upon locked outputs bucket deletion #731

Merged
merged 1 commit into from
Feb 17, 2021
Merged

wtxmgr: ignore ErrBucketNotFound error upon locked outputs bucket deletion #731

merged 1 commit into from
Feb 17, 2021

Conversation

wpaulino
Copy link
Contributor

This error would be seen when an old wallet that has yet to update is performing the latest wtxmgr migration. It's possible for the locked outputs bucket to not exist if outputs haven't been locked before, so we should its deletion correctly.

…etion

This error would be seen when an old wallet that has yet to update is
performing the latest wtxmgr migration. It's possible for the locked
outputs bucket to not exist if outputs haven't been locked before, so we
should its deletion correctly.
Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, LGTM 🎉

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌺

@Roasbeef Roasbeef merged commit 39cbb7b into btcsuite:master Feb 17, 2021
@wpaulino wpaulino deleted the wtxmgr-migration-delete-bucket-fix branch February 17, 2021 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants