Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for reorganizations from ppcwallet #277

Closed
wants to merge 1 commit into from

Conversation

cjepson
Copy link

@cjepson cjepson commented May 13, 2015

Wallet had an issue in which blocks failed to be removed from wtxmgr by
disconnectBlock for long (>20 block) reorganizations because Rollback
failed to be called. This fix was written by mably for ppcwallet,
commit ffb1eee.

Wallet had an issue in which blocks failed to be removed from wtxmgr by
disconnectBlock for long (>20 block) reorganizations because Rollback
failed to be called. This fix was written by mably for ppcwallet,
commit ffb1eee.
@jrick
Copy link
Member

jrick commented May 13, 2015

This fix isn't quite right. The rollback will occur starting at the last recent block saved by the address manager, but the address manager may then be marked totally unsynced. Instead, another rollback should be done in the else case that rolls back block 1 onwards (everything but the genesis block).

@jrick
Copy link
Member

jrick commented May 14, 2015

Closing in favor of #281, which uses the fix I described above.

@jrick jrick closed this May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants