Update File Outline outline view to use view-based table cells #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Outstanding issues: - Selection is lost during reloads (and causes issues deselecting!)
…console every time a part is selected.
• Also set outlive view cell text from delegate method instead of using Cocoa Bindings (for consistency with icon image using the same method) • Remove code from previous attempts to fix outline view selection • Minor stylistic changes
• Also updates outline view cells to use auto layout constraints to ensure proper sizing when using Source List styling
undecoded-coder
commented
Feb 15, 2022
| // actually catch something unexpected here, but as the majority of | ||
| // meta commands we could possibly care about include the prefix, it | ||
| // seems like a good balance. | ||
| if ([parsedField containsString:@"!"]) | ||
| printf("Unparsable META command: %s\n", [orig_line UTF8String]); |
There was a problem hiding this comment.
As I’m not sure what the actual intention of this logging is, it may be that something just needs updated so that normal meta commands aren’t reaching this; or maybe this logging should be removed altogether?
I was just having trouble doing some debugging with the console filled with every comment or meta command in the related parts file so I did this so I wouldn’t have to deal with it. If there is something else you would rather do let me know.
|
@allenmonroesmith I think this is at a point it can be merged if everything looks good to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the File Outline
NSOutlineViewto be view-based (#15), including usingNSImageViewfor native icon image rendering and removing its dependency on theIconTextCellclass.Note: Due to changes in
NSOutlineView/NSTableViewwhen using view-based table cells, namely that selection is not persisted across calls to-reloadDatasince the row views will be entirely discarded during a reload, it was necessary to make changes to how selection is managed in-[LDrawDocument docChanged:]in order to properly manage selection.Other changes:
related.ldr