Test with multiple DB engines #35
Conversation
dim
force-pushed
the
ci/multi-db
branch
14 times, most recently
from
30f7c94 to
d722897
Compare
| @@ -15,7 +15,13 @@ def self.truncate! | |||
| scope :created_before, ->(date = 1.month.ago) { where(arel_table[:created_at].lt(date)) } | |||
|
|
|||
| def self.namespaced(namespace) | |||
| where(arel_table[:key].matches("#{namespace}:%")) | |||
| case ActiveRecord::Base.connection.adapter_name | |||
| when 'PostgreSQL' | |||
There was a problem hiding this comment.
suggestion: In most cases, ActiveRecord::Base.connection.adapter_name will return 'PostgreSQL'. But there are cases where this might no be true, even if PostgreSQL is used.
There are so much factors, when this value could look different e.g. non pg database driver, wrapper for pg driver or even database adapter naming in database.yml could alter AR.adapter_name due to unspoken conventions of ActiveRecord.
And in general, even huge PG fans still can't agree on how to capitalize PostgreSQL name.
I would recommend to go with this as a method to detect PG adapters.
ActiveRecord::Base.connection.adapter_name =~ /postg/
| case ActiveRecord::Base.connection.adapter_name | ||
| when 'PostgreSQL' | ||
| ifx = Arel::Nodes::InfixOperation.new('IN', Arel::Nodes.build_quoted(namespace), arel_table[:key]) | ||
| where(Arel::Nodes::NamedFunction.new('POSITION', [ifx]).eq(1)) |
There was a problem hiding this comment.
issue: I might be mistaken, I don't have big exposure with MySQL and MariaDB.
But this AREL query could be used for MariaDB/MySQL case as well.
Seems like IN/POSITION is supported by both. I couldn't find mentions about IN in documentation, but I found comments in various pages where people mention that it works.
Sqlite doesn't seem to support POSITION, though.
Fixes #33