-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start work on excluding unnecessary CMake modules #91
Conversation
I realize that this could also be a work-around for CI caching. Once we publish |
Ah yeah, if that works well then I'd much prefer that approach. |
Trying hard to cut out all unnecessary files to keep the crate size under the 10MB limit - I think we may need a different approach of splitting up toolkits into different crates. I've gotten fairly good at controlling which "toolkits" (as occt calls them) get built, but getting them all to fit in one crate is looking very difficult and time consuming to accomplish. |
Issues linked to rust-lang/crates.io#195 seem to be like a good library of workarounds people do to circumvent the limit.
|
cc @mkovaxx |
@strohel if we specify |
05afa1e
to
da50dd8
Compare
727dcd7
to
8cf900d
Compare
9c9009a
to
91417ad
Compare
Merging this for now, there can be some cleanup afterwards but I want to get this in now to get CI build times down. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Goals of this PR:
occt-sys
crate to below 10 MB, the crates.io upload limitI realized we can override opencascade files with the CMake
BUILD_PATCH
variable. I recreated theadm/MODULES
directory in our patch directory and verified that CMake picks it up and uses it instead of the file in OCCT.Next step is to modify
adm/MODULES
to cut out things we don't need, as well as editingocct-sys/Cargo.toml
to exclude big directories that we don't use anyway.Here's a reference to some of the CMake stuff in occt.
Depends on #112 being merged first.