-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update glam dependency to allow 0.24.1 #124
Conversation
changes changes changes revert some changes
@strohel I'm curious about your opinion on this one as well. I also don't want to re-export Should I go back to
From what I can tell, the bet is determining which of the two happen more often:
or
Which do we think will happen more often in the future? And have I described the overall scenarios correctly? |
Yeah, deciding how to notate the version requirement was a bit problematic. If the One approach is to just allow anything and then adjust if there are problems. Or go with something like Just my 2 cents. |
I don't think it will be too much of a pain to maintain this as it is, I just wanted to explore all the options out there. In practice this should be simple to update as I don't imagine we'll be using the more advanced features of @TomiS do you think I should apply the same version range to |
@bschwind Probably. But you might want to validate somehow that everything works as expected. |
I played around with this a bit:
I end up getting type errors as you would see with multiple versions of the same crate in the graph. I thought it would select I think this explanation describes what is happening. Here's another related issue I'll try to play around with this more to find the most sensible version range we should set. |
Trying to allow using latest version of
glam
to make it possible to useopencascade-rs
with, for example, the latest[email protected]
At least examples seem to run correctly, but it's quite possible
simple-game
also needs updating to avoid duplicate dependency.