Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: makes generating videos more programmatic. #473

Closed
wants to merge 1 commit into from

Conversation

jaydrennan
Copy link
Collaborator

the generate_video function previously involved logic for saving the new file and wouldn't return anything. now it will return a list of the generated samples.

@jaydrennan jaydrennan force-pushed the update_video_gen branch 3 times, most recently from dba3ce2 to bc13890 Compare March 2, 2024 02:18
@brycedrennan
Copy link
Owner

tests are fixed in master

the generate_video function previously involved logic for saving the new file and wouldn't return anything. now it will return a list of the generated samples.
@brycedrennan
Copy link
Owner

Add a test. Mock out model.sampler function to return a torch tensor of shape [6, 4, 8, 8]

Copy link
Owner

@brycedrennan brycedrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

videos not being saved

@jaydrennan jaydrennan marked this pull request as draft March 14, 2024 18:19
@brycedrennan
Copy link
Owner

Feel free to reopen if you get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants