patch/#35 Retry previous block height requests if error #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es a possible lower height to retrieve. Use when retrieving a previous block for calculating the estimated upgrade time
|
You should start thinking in adding better design patterns here. Maybe a circuit breaker would do better than this solution. But thanks! |
|
Can you explain what you mean by circuit breaker and how it will resolve the ability to estimate public RPC servers with lower block history? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry into block time request if allowed and if the error indicates a possible lowest available height to retrieve. Use when retrieving a previous block for calculating the estimated upgrade time