Add cointracker and TaxBit CSV parsers #234
Conversation
davidkonigsberg
commented
Jan 11, 2023
davidkonigsberg
commented
- First I cleaned up the parser code to make it easier to extend
|
Going to add both parsers with this PR, so this PR also closes #233 |
davidkonigsberg
changed the title
|
Been doing some local tests today, and the initial tests of the coin tracker code look good. While I have added support for the coin tracker tags, I am not using them anywhere. Firstly, they are optional, so I don't think we need to spend time on it for the grant (@KyleMoser and @danbryan let me know if you disagree). Secondly, they are subjective. The difference between a Gift and a Donation are determined require knowledge of the destination wallet. I think if we spend a lot of time on it, we might be able to figure out some of the other tags, but that will require more time and more knowledge of the specific msgs types and how coin tracker actually uses these tags.... TLDR: I think v0 of the coin tracker support is done. I am going to move on to working on the tax bit stuff. My hope is that we can get these both merged in this week or early next week at the latest, then @danbryan maybe you can do a bit of testing and create any tickets needed to resolve any bugs you find. I don't think our other parsers (koinly and accointing) are perfect either. |
|
Local testing is looking ok for TaxBit, but testing in their system is slow. I have uploaded CSVs but the data hasn't shown up. They say it can take up to an hr, so before I open a ticket with them or anything I am waiting to see what happens. If TXs don't show up later today I will open a support ticket to look into this. |
|
Ok, so after playing around with things I determine that the CSV uploads will ONLY work if the spruce is set. I can't leave it blank. @danbryan what do you think of me specifying "Hardware Wallet" for all transactions? |
|
I added that, and now I am at least able to upload the transaction and view them in TaxBit |
|
Ok, so, TaxBit is now working too, at least to the point that I can upload stuff and view it in the tax bit UI. As with coin tracker, there are some tags we simply can't add. To know the difference between a sale, an expense, a gift, and a transfer we need more information than we have. I think what we do have is enough to start on though. What I think we should do, at least in the near term, is provide documentation to users that explains the manual steps that will need to happen. While there are things we can do automatically, at the end of the day, there will ALWAYS be some manual steps required. Beyond this though, I think we are good. I have tested locally and the generated CSVs look good. I have also uploaded CSVs to both websites and they show up in a way that I think broadly correct. As above, I say we merge this stuff in and then make more explicit tickets for any bugs we find during testing. I think we have what we need to merge this. @KyleMoser @danbryan what do you think? I am AFK for the rest of the day for non-defiant work, but if you are happy with what we have here I can merge it tomorrow and start working on some of the other high priority tickets while @danbryan does some testing. Thoughts? |
|
sounds good to me. I think some items should be left up to the user to categorize. We have no idea if the funds they received were for services rendered, or a gift. I would just leave those blank and let the user fill that out in taxbit/cointracker |
* simplify parser code * add cointracker parser * break down test code * Add initial support for taxbit
