Switch from titled "Dismiss" button do system done #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you help me understand what's misleading about the current "Dismiss" title? |
|
I have many users that are used to FBTweaks window and they notice right away that there is no "Done" button and they where confused if changes will be discarded or not. |
|
Ah, gotcha! Yeah that sounds good to me - thanks for updating it to a system-standard so it'll (hopefully?) auto-translate for folks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I would like to propose change in labelling of end of tweak edition button. Current
Dismissis misleading to some people since it point to hiding Tweaks so I would like to proposeDone- it's same how it was in FB Tweaks. Also I am switching here to system button so it should be nicely translated to all languages.