Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for static library and xcframeworks #156

Merged

Conversation

atom-wintermute
Copy link
Contributor

Use "resource_bundle" instead of "resources" in podspec for allowing build the app with static framework linking

@atom-wintermute
Copy link
Contributor Author

@bryanjclark please, take a look 🙏

@bryanjclark
Copy link
Owner

Hi! This looks good to me, but also I'm not at KA anymore, so I'm going to ask my former-teammates how to proceed with this change. Thank you for the PR!

@bryanjclark
Copy link
Owner

Alright, got that sorted. I'll get this merged in!

@bryanjclark bryanjclark merged commit 6c4c886 into bryanjclark:master Jul 28, 2021
@VilemKurz
Copy link

Please, release this.

@JoeSzymanski
Copy link

I'm not sure how this was missed, but as far as I can tell, this change causes a crash for all submenu access in SwiftTweaks when integrating via Cocoapods. I opened an issue to track this: #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants