Skip to content

Commit

Permalink
Add msys2 workflow for CMake (HDFGroup#4991)
Browse files Browse the repository at this point in the history
Also updates CMake configure checks to build HDF5 w/ MSYS2
  • Loading branch information
byrnHDF authored and brtnfld committed Nov 4, 2024
1 parent 98ff724 commit f4b91bd
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 7 deletions.
16 changes: 11 additions & 5 deletions .github/workflows/cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,14 @@ jobs:
name: "CMake TestExpress Workflows"
uses: ./.github/workflows/testxpr-cmake.yml

# call-release-cmake-julia:
# name: "CMake Julia Workflows"
# uses: ./.github/workflows/julia-cmake.yml
# with:
# build_mode: "Release"
# call-release-cmake-julia:
# name: "CMake Julia Workflows"
# uses: ./.github/workflows/julia-cmake.yml
# with:
# build_mode: "Release"

call-release-cmake-msys2:
name: "CMake Msys2 Workflows"
uses: ./.github/workflows/msys2-cmake.yml
with:
build_mode: "Release"
4 changes: 2 additions & 2 deletions .github/workflows/msys2-cmake.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ jobs:

- name: CMake Run Tests
run: |
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V -E "testhdf5-base|cache_api|dt_arith|H5TEST-dtypes|err_compat"
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V -E "tfloatsattrs|testhdf5-base|cache_api|dt_arith|H5TEST-dtypes|err_compat"
working-directory: ${{ runner.workspace }}/build

- name: CMake Run Expected to Fail Tests
run: |
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V -R "testhdf5-base|cache_api|dt_arith|H5TEST-dtypes|err_compat"
ctest . --parallel 2 -C ${{ inputs.build_mode }} -V -R "tfloatsattrs|testhdf5-base|cache_api|dt_arith|H5TEST-dtypes|err_compat"
working-directory: ${{ runner.workspace }}/build
continue-on-error: true
12 changes: 12 additions & 0 deletions release_docs/RELEASE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,18 @@ New Features

Configuration:
-------------
- Added support for MinGW + MSYS2 when building with CMake

We previously added support for this to the Autotools and the appropriate
configure-time checks have been added to CMake.

CMake + MinGW + MSYS2 is now tested with the following environments:

* mingw32
* mingw64
* ucrt64
* clang64

- Added CMake build mode flags to the libhdf5.settings file

Flags from the CMake build mode (e.g., optimization) are not a part of
Expand Down

0 comments on commit f4b91bd

Please sign in to comment.