Merge branch 'master' into fix_filename_retries_a11y

browserstack · Jan 28, 2025 · 796dcb0 · 796dcb0
2 parents 87eafae + c0a748d
commit 796dcb0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/bin/commands/runs.js b/bin/commands/runs.js
@@ -365,10 +365,10 @@ module.exports = function run(args, rawArgs) {
                       }
 
                       // Generate custom report!
-                      reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(){
+                      reportGenerator(bsConfig, data.build_id, args, rawArgs, buildReportData, function(modifiedExitCode=exitCode){
                         utils.sendUsageReport(bsConfig, args, `${message}\n${dashboardLink}`, Constants.messageTypes.SUCCESS, null, buildReportData, rawArgs);
                         markBlockEnd('postBuild');
-                        utils.handleSyncExit(exitCode, data.dashboard_url);
+                        utils.handleSyncExit(modifiedExitCode, data.dashboard_url);
                       });
                     } else if(!turboScaleSession){
                       let stacktraceUrl = getStackTraceUrl();

diff --git a/bin/helpers/reporterHTML.js b/bin/helpers/reporterHTML.js
@@ -105,6 +105,9 @@ let reportGenerator = async (bsConfig, buildId, args, rawArgs, buildReportData,
     logger.error('Generating the build report failed.');
     logger.error(utils.formatRequest(error.response.statusText, error.response, error.response.data));
     utils.sendUsageReport(bsConfig, args, message, messageType, errorCode, buildReportData, rawArgs);
+    if (cb){
+      cb(Constants.ERROR_EXIT_CODE);
+    }
     return;
   }
 }