Skip to content

Count iOS safari-based browsers as safari #1

Merged
merged 3 commits into from
Mar 17, 2018

Conversation

Vasfed
Copy link
Contributor

@Vasfed Vasfed commented Mar 16, 2018

All apps on iOS must use safari engine by apple rules.
This PR will make safari-based iOS browsers count as safari thus improving stats

@dmfrancisco
Copy link
Member

Thank you for your contribution 👍 It seems if we change this we can simplify the condition above this one too. The conditionals we have today match what is done at caniuse.com, when you import your Google Analytics. It would be nice if we kept it this way, but on the other hand these conditionals are a bit confusing and your changes seem to make sense!

Have you noticed differences in your browserslist-stats.json when using your version? When I use it with my own analytics I don't see any changes because my iOS traffic always shows up as Safari, Chrome or Safari (in-app).

@Vasfed
Copy link
Contributor Author

Vasfed commented Mar 17, 2018

@dmfrancisco you're right, conditions may be further simplified.

Found the reason, in original data items are like

[
    "iOS",
    "9.3.5",
    "YaBrowser",
    "9.0",
    "Yes",
    "5808"
  ]

Have you see any iOS app in stats? Looks like we may remove this completely and replace all iOS/iPhone/iPad/... with safari

@dmfrancisco
Copy link
Member

This looks good 👍 Thank you again!

@dmfrancisco dmfrancisco merged commit 5a56ca8 into browserslist:master Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants