Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brave browser #26

Merged
merged 1 commit into from
Mar 13, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,22 @@ hosts-vivaldi-user:
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac

.PHONY: hosts-brave
hosts-brave:
@case $(OS) in \
Linux) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "/etc/opt/brave/native-messaging-hosts/" ;; \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this is correct path, but /etc/opt/chrome/native-messaging-hosts/ in browserpass/browserpass-legacy#295 was probably wrong too — let's see if someone confirms or fixes this :)

Darwin) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "/Library/Application Support/BraveSoftware/Brave-Browser/NativeMessagingHosts/" ;; \
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac

.PHONY: hosts-brave-user
hosts-brave-user:
@case $(OS) in \
Linux|OpenBSD|FreeBSD) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "${HOME}/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/" ;; \
Darwin) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "${HOME}/Library/Application Support/BraveSoftware/Brave-Browser/NativeMessagingHosts/" ;; \
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac

.PHONY: hosts-firefox
hosts-firefox:
@case $(OS) in \
Expand Down Expand Up @@ -184,3 +200,19 @@ policies-vivaldi-user:
Darwin) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "${HOME}/Library/Application Support/Vivaldi/policies/managed/" ;; \
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac

.PHONY: policies-brave
policies-brave:
@case $(OS) in \
Linux) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "/etc/opt/brave/policies/managed/" ;; \
Darwin) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "/Library/Application Support/BraveSoftware/Brave-Browser/policies/managed/" ;; \
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac

.PHONY: policies-brave-user
policies-brave-user:
@case $(OS) in \
Linux|OpenBSD|FreeBSD) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "${HOME}/.config/BraveSoftware/Brave-Browser/policies/managed/" ;; \
Darwin) ln -sf "$(DESTDIR)/usr/lib/browserpass/hosts/chromium/$(APP_ID).json" "${HOME}/Library/Application Support/BraveSoftware/Brave-Browser/policies/managed/" ;; \
*) echo "The operating system $(OS) is not supported"; exit 1 ;; \
esac
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ The Makefile (which is also available in `/usr/lib/browserpass/`, if you install
| `make hosts-chrome-user` | Configure browserpass for Google Chrome browser, for the current user only |
| `make hosts-vivaldi` | Configure browserpass for Vivaldi browser, system-wide |
| `make hosts-vivaldi-user` | Configure browserpass for Vivaldi browser, for the current user only |
| `make hosts-brave` | Configure browserpass for Brave browser, system-wide |
| `make hosts-brave-user` | Configure browserpass for Brave browser, for the current user only |
| `make hosts-firefox` | Configure browserpass for Firefox browser, system-wide |
| `make hosts-firefox-user` | Configure browserpass for Firefox browser, for the current user only |

Expand All @@ -59,8 +61,8 @@ In addition, Chromium-based browsers support the following `make` goals:
| `make policies-chromium-user` | Automatically install browser extension for Chromium browser, for the current user only |
| `make policies-chrome` | Automatically install browser extension for Google Chrome browser, system-wide |
| `make policies-chrome-user` | Automatically install browser extension for Google Chrome browser, for the current user only |
| `make policies-vivaldi` | Automatically install browser extension for Vivaldi browser, system-wide |
| `make policies-vivaldi-user` | Automatically install browser extension for Vivaldi browser, for the current user only |
| `make policies-brave` | Automatically install browser extension for Brave browser, system-wide |
| `make policies-brave-user` | Automatically install browser extension for Brave browser, for the current user only |

## Building the app

Expand Down