Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Exclude tests and config files from publish #296

Closed
wants to merge 1 commit into from

Conversation

dosisod
Copy link

@dosisod dosisod commented Apr 2, 2023

Tests and config files don't need to be in the published package (the test folder alone is over half the size of the total package!). We might want to keep the example folder though, so I can change that if we want to keep it in the release.

@ljharb
Copy link
Member

ljharb commented Apr 2, 2023

Yes, they absolutely need to be in the published package - npm explore foo && npm install && npm test should always work. Those files must be included, and will forever be.

Note that this would be a breaking change.

Duplicate of #281. Duplicate of #279. Duplicate of #239. Duplicate of #235. Duplicate of #58. Duplicate of #44. See #105 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants