fix error listener handler case

Port of nodejs/node@a62ff6d
browserify · Feb 27, 2021 · 133faed · 133faed
1 parent f1d67b0
commit 133faed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/events.js b/events.js
@@ -461,7 +461,9 @@ function once(emitter, name) {
     };
 
     eventTargetAgnosticAddListener(emitter, name, resolver, { once: true });
-    addErrorHandlerIfEventEmitter(emitter, errorListener, { once: true });
+    if (name !== 'error') {
+      addErrorHandlerIfEventEmitter(emitter, errorListener, { once: true });
+    }
   });
 }
 

diff --git a/tests/events-once.js b/tests/events-once.js
@@ -134,7 +134,9 @@ function onceError() {
     ee.emit('error', expected);
   });
 
-  return once(ee, 'error').then(function (args) {
+  var promise = once(ee, 'error');
+  assert.strictEqual(ee.listenerCount('error'), 1);
+  return promise.then(function (args) {
     var err = args[0]
     assert.strictEqual(err, expected);
     assert.strictEqual(ee.listenerCount('error'), 0);