Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BC Break] Add support for Symfony 6 (from @Slamdunk) #418

Merged
merged 3 commits into from
Feb 23, 2022
+55 −213
Merged

[BC Break] Add support for Symfony 6 (from @Slamdunk) #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e0615
Allow Symfony 6
Slamdunk Jan 26, 2022
8fd2b8a
Ensure we are using BCC 6.1.1 and newer
asgrim Feb 23, 2022
7a62648
Mark all extensions from Symfony components as @internal as we cannot…
asgrim Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/continuous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ jobs:
restore-keys: "php-${{ matrix.php-version }}-composer-${{ matrix.dependencies }}-"

- name: "Require Roave/BackwardCompatibilityCheck"
run: "composer require --no-update --no-interaction --prefer-dist --prefer-stable --dev \"roave/backward-compatibility-check:6.0.x-dev\" \"roave/better-reflection:5.0.x-dev\""
run: "composer require --no-update --no-interaction --prefer-dist --prefer-stable \"roave/backward-compatibility-check:^6.1.1\""

- name: "Composer update with new requirements"
run: "composer update --no-interaction --prefer-dist --prefer-stable"
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"monolog/monolog": "^2.3.5",
"psr/log": "^1.1.4 || ^2.0.0 || ^3.0.0",
"psr/simple-cache": "^1.0.1",
"symfony/console": "^5.4.0",
"symfony/filesystem": "^5.4.0"
"symfony/console": "^5.4.0 || ^6.0.0",
"symfony/filesystem": "^5.4.0 || ^6.0.0"
asgrim marked this conversation as resolved.
Show resolved Hide resolved
},
"require-dev": {
"doctrine/coding-standard": "^9.0.0",
Expand Down
241 changes: 37 additions & 204 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/Command/CheckUpdateCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
/**
* Command to fetch a browscap ini file from the remote host, convert it into an array and store the content in a local
* file
*
* @internal This extends Symfony API, and we do not want to expose upstream BC breaks, so we DO NOT promise BC on this
*/
class CheckUpdateCommand extends Command
{
Expand Down
2 changes: 2 additions & 0 deletions src/Command/ConvertCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@

/**
* Command to convert a downloaded Browscap ini file and write it to the cache
*
* @internal This extends Symfony API, and we do not want to expose upstream BC breaks, so we DO NOT promise BC on this
*/
class ConvertCommand extends Command
{
Expand Down
2 changes: 2 additions & 0 deletions src/Command/FetchCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@

/**
* Command to fetch a browscap ini file from the remote host and store the content in a local file
*
* @internal This extends Symfony API, and we do not want to expose upstream BC breaks, so we DO NOT promise BC on this
*/
class FetchCommand extends Command
{
Expand Down
Loading