-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build warning #702
Labels
Comments
Yes I tried a few things but couldn't make it work without warning. I decided to go with what worked, but I guess it might break at some point. Would be nice to fix 👍 |
🎉 This issue has been resolved in version 6.2.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 6.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The terminal warning I'm getting
Not 100% sure you can use named imports on css files like this even though Webpack css-loader references this exact usage.
gatsby-image-gallery/gatsby-image-gallery/src/index.tsx
Line 9 in 197b551
Should be able to just import the CSS per docs recommendation.
import 'react-image-lightbox/style.css';
and skip this.
gatsby-image-gallery/gatsby-image-gallery/src/index.tsx
Lines 31 to 33 in 197b551
Seems like the styles are working though hence just a warning and this package in my tests is functioning as intended
I'll try to open a PR to test and or fix this just wanted to get your thoughts
The text was updated successfully, but these errors were encountered: