Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warning #702

Closed
wildpow opened this issue May 14, 2021 · 3 comments · Fixed by #703
Closed

Build warning #702

wildpow opened this issue May 14, 2021 · 3 comments · Fixed by #703
Labels

Comments

@wildpow
Copy link

wildpow commented May 14, 2021

The terminal warning I'm getting

warn ./node_modules/@browniebroke/gatsby-image-gallery/dist/gatsby-image-gallery.esm.js
Attempted import error: 'react-image-lightbox/style.css' does not contain a default export (imported as 'LightboxCSS').

Not 100% sure you can use named imports on css files like this even though Webpack css-loader references this exact usage.

import LightboxCSS from 'react-image-lightbox/style.css'

Should be able to just import the CSS per docs recommendation.
import 'react-image-lightbox/style.css';

and skip this.

const StyledLightbox = styled(Lightbox)`
${LightboxCSS}
`

Seems like the styles are working though hence just a warning and this package in my tests is functioning as intended

I'll try to open a PR to test and or fix this just wanted to get your thoughts

@browniebroke
Copy link
Owner

Yes I tried a few things but couldn't make it work without warning. I decided to go with what worked, but I guess it might break at some point. Would be nice to fix 👍

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.1-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants