Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 peer dependency #629

Closed
browniebroke opened this issue Jan 24, 2021 · 3 comments · Fixed by #741
Closed

React 17 peer dependency #629

browniebroke opened this issue Jan 24, 2021 · 3 comments · Fixed by #741
Labels
help wanted Extra attention is needed released

Comments

@browniebroke
Copy link
Owner

Although it works fine (AFAIK), when installing on a project running React 17, we have these warnings:

warning "@browniebroke/gatsby-image-gallery > [email protected]" has incorrect peer dependency "react@^16.x".
warning "@browniebroke/gatsby-image-gallery > [email protected]" has incorrect peer dependency "react-dom@^16.x".

The react-image-lightbox dependency hasn't been updated in a while, might consider switching to another one if the situation persists. I will list here some interesting options as I find them:

@browniebroke browniebroke added the help wanted Extra attention is needed label Jan 24, 2021
@wildpow
Copy link

wildpow commented May 14, 2021

Had a similar issue with react-move but, it's another almost unmaintained project and my PR is collecting dust.
I am building a project that needs an image gallery just like this project but, most examples I've found use either unmaintained modules or the old gatsby-image. I was going to fork react-awsome-lightbox (because it looks somewhat maintained) to work with gatsby-image-plugin but, this project may do nicely.

P.S PR for react-image-lightbox will see how long that takes to get merged 🦀

@wildpow
Copy link

wildpow commented May 14, 2021

Well tried out simple-react-lightbox and there is a lot to like. For instance, I get to keep my custom masonry gallery and get a lightbox/carousel almost for free just put it in between provided HOC, and done. Unfortunately, this package bundle is huge! Vscode estimates 298K before gzip effectively doubling my bundle size of the small site I'm working on. The combination of increased bundles size and dropping 25 point in lighthouse would be a non-starter for me personally.

PR #142 shaves 50Kb by changing lodash imports but even 240Kb is a tough pill to swallow.

browniebroke added a commit that referenced this issue Jul 14, 2021
The peer dependency has been updated to allow React 17.

Fix #629
browniebroke added a commit that referenced this issue Jul 14, 2021
The peer dependency has been updated to allow React 17.

Fix #629
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 6.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants