Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update upload_model_executions.sql #349

Merged
merged 2 commits into from
May 30, 2023
Merged

Update upload_model_executions.sql #349

merged 2 commits into from
May 30, 2023

Conversation

kanomaxb
Copy link
Contributor

Replace single quotes and other special characters in model.message.

Overview

Fix problem which prevents from saving error messages that contain single quotes.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Fix problem that prevents from saving error messages that contain single quotes. This problem got described by jeremyyeo in #316

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@kanomaxb
Update upload_model_executions.sql
84cbbda 
Replace single quotes and other special characters in model.message.
@kanomaxb kanomaxb had a problem deploying to Approve Integration Tests May 29, 2023 13:29 — with GitHub Actions Failure
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 29, 2023 13:29 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 29, 2023 13:29 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:09 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:10 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:10 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:10 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:10 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 09:10 — with GitHub Actions Inactive
jared-rimmer
jared-rimmer reviewed May 30, 2023
View reviewed changes
Copy link
Member

@jared-rimmer jared-rimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kamilamarcinekpgs!

If you're happy to do so it would be good to add the same changes to seed_executions and snapshot_executions

@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 11:08 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 11:08 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 11:08 — with GitHub Actions Inactive
@kanomaxb
Copy link
Contributor Author

Of course, @jared-rimmer. I've just added requested changes.

@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@kanomaxb kanomaxb temporarily deployed to Approve Integration Tests May 30, 2023 12:00 — with GitHub Actions Inactive
@jared-rimmer jared-rimmer merged commit 29509e0 into brooklyn-data:main May 30, 2023
@kanomaxb kanomaxb deleted the kamilamarcinekpgs-single-quotes branch May 30, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jared-rimmer jared-rimmer jared-rimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanomaxb @jared-rimmer