Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with ' in meta field #315

Merged
merged 4 commits into from
May 25, 2023
Merged

Fix issue with ' in meta field #315

merged 4 commits into from
May 25, 2023

Conversation

glsdown
Copy link
Contributor

@glsdown glsdown commented May 12, 2023 •
edited
Loading

Overview

This aims to fix the issues when there is an apostrophe in the meta field. I have additionally added an example meta field within a model to test this.

Edit: as dbx CI checks are not currently running (see #342 ), I have confirmed that it runs locally using dbx on 1.4 and 1.5.

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)

What does this solve?

Outstanding questions

None

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 16:25 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 16:25 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 12, 2023 16:25 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 12, 2023 16:25 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown temporarily deployed to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown had a problem deploying to Approve Integration Tests May 18, 2023 13:09 — with GitHub Actions Error
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 14:33 — with GitHub Actions Inactive
@glsdown glsdown mentioned this pull request May 22, 2023
Closed
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 15:09 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 15:09 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 22, 2023 15:09 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 15:09 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 15:19 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 22, 2023 15:19 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 22, 2023 15:19 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 23, 2023 13:21 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 23, 2023 13:21 — with GitHub Actions Inactive
@glsdown glsdown had a problem deploying to Approve Integration Tests May 23, 2023 13:21 — with GitHub Actions Error
@glsdown glsdown temporarily deployed to Approve Integration Tests May 23, 2023 13:21 — with GitHub Actions Inactive
@glsdown glsdown force-pushed the fix/fix-issue-with-apostrophes-in-meta-field branch from 5d6fa2b to 19fd594 Compare May 25, 2023 10:43
@glsdown glsdown had a problem deploying to Approve Integration Tests May 25, 2023 10:43 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 25, 2023 10:43 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 25, 2023 10:43 — with GitHub Actions Failure
@glsdown glsdown had a problem deploying to Approve Integration Tests May 25, 2023 10:43 — with GitHub Actions Failure
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:44 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:44 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:44 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown temporarily deployed to Approve Integration Tests May 25, 2023 10:48 — with GitHub Actions Inactive
@glsdown glsdown merged commit 935c8a1 into main May 25, 2023
@glsdown glsdown deleted the fix/fix-issue-with-apostrophes-in-meta-field branch May 25, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jared-rimmer jared-rimmer jared-rimmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: apostrophe in a meta config breaks the models insert sql statement
2 participants
@glsdown @jared-rimmer