Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe cast field to INT to avoid failure on casting error #217

Merged

Conversation

ahmedrad
Copy link
Contributor

@ahmedrad ahmedrad commented Oct 6, 2022

Failures in the run-end-hook are occurring in snowflake production because the extracted rows_affected field from the manifest is a string and occasionally fails insertion into an INT column

Adding safe casting to avoid failure.

In our case, what's causing the failure is a custom materialization type called insert_by_period in a 3rd party package that's reporting the rows_affected as an empty string. Bigquery already has the casting implemented so it makes sense to add the same for snowflake!

@ahmedrad ahmedrad temporarily deployed to Approve Integration Tests October 6, 2022 05:35 Inactive
@ahmedrad ahmedrad temporarily deployed to Approve Integration Tests October 6, 2022 05:35 Inactive
@ahmedrad ahmedrad temporarily deployed to Approve Integration Tests October 6, 2022 05:35 Inactive
@ahmedrad ahmedrad temporarily deployed to Approve Integration Tests October 6, 2022 05:35 Inactive
@ahmedrad
Copy link
Contributor Author

ahmedrad commented Oct 6, 2022

Hey @NiallRees would love it if you can release this in a minor version when you can. Let me know if there's any more work needed for it

@NiallRees NiallRees merged commit 34b5936 into brooklyn-data:main Oct 8, 2022
@ahmedrad
Copy link
Contributor Author

hey @NiallRees do you have plans to release this in a minor version update soon?

@NiallRees
Copy link
Contributor

Hi @ahmedrad - I've just released 2.1.1 with this change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants