Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tests add fields #177

Closed

Conversation

patkearns10
Copy link

Adding a few Test dimensions that could make analysis a bit easier.

short_name= shorter version of the test name, example. 'unique', instead of long name unique_my_first_model_col
test_type= 'singular' or 'generic'
test_severity_config= 'ERROR' or 'WARN'
model_refs= short name of model dependencies
source_refs= short name of src dependencies

@patkearns10 patkearns10 had a problem deploying to Approve Integration Tests August 18, 2022 04:55 Failure
@patkearns10 patkearns10 had a problem deploying to Approve Integration Tests August 18, 2022 04:55 Failure
@jaypeedevlin
Copy link
Contributor

Hey Pat!

I just left a comment on another PR explaining the delay here: TL;DR we hadn't thought through schema migrations for new fields and are grappling with that now!

Stay tuned!

@patkearns10
Copy link
Author

Thanks for the info -- no rush on my end!

@jaypeedevlin
Copy link
Contributor

Hey @patkearns10 I just merged 188 which unblocks this. My recommendation might actually be closing this PR and reopening a fresh one rather than trying to rebase since so much code changed in that PR. Up to you of course!

@NiallRees
Copy link
Contributor

Hey @patkearns10, let us know if we can help out at all with getting this ready for merge. They’re really great additions!

@patkearns10
Copy link
Author

patkearns10 commented Sep 29, 2022 via email

@patkearns10
Copy link
Author

Closing this in favor of #213

@patkearns10 patkearns10 closed this Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants