Don't use arrow function introduced in 2.4.1 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is ES6 syntax introduced in the latest release 2.4.1. Meanwhile the whole package is written in ES5 (`var` instead of `const`, etc). Introducing this tiny use of arrow function renders usage of this module in browsers like IE11 impossible. I hope it's not a big deal to stick with older syntax to remain consistent with code style and browser/node support
slavik-chapelskyi
approved these changes
Apr 5, 2019
KnupMan
approved these changes
Apr 5, 2019
|
Whups, my bad! 'Been writing ES6 almost exclusively for over a year now and muscle memory took over. Thanks for the catch and fix. Published in 2.4.2 |
|
Thanks @broofa for a prompt release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is ES6 syntax introduced in the latest release 2.4.1. Meanwhile the whole package is written in ES5 (
varinstead ofconst, etc).Introducing this tiny use of arrow function renders usage of this module in browsers like IE11 impossible.
I hope it's not a big deal to stick with older syntax to remain consistent with code style and browser/node support
See #221 (comment)
If you have an issue with a specific extension or type
Locate the definition for your extension/type in the db.json file in the
mime-dbproject. Does it look right?mime-dbissue.