-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Add support to decouple actions and exceptions #5
[FR] Add support to decouple actions and exceptions #5
Conversation
|
||
|
||
@dataclass | ||
class Action(MarshmallowDataclassMixin): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class ActionMeta(MarshmallowDataclassMixin): | ||
"""Data stored in an exception's [metadata] section of TOML.""" | ||
creation_date: definitions.Date | ||
rule_id: definitions.UUIDString |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should action list be associated to only one rule or multiple rules?
@brokensound77 here is an example toml file based on the actions:
I noticed that ActionParams may need to be updated and |
Sample exception list file:
|
self.frozen = True | ||
|
||
@classmethod | ||
def default(cls) -> 'GenericCollection': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will there be unit tests that load this Generic Collection? Just thinking about how a user will test this prior to trying to push to kibana and loading everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not built in - but if they wanted to unit test similar to how we do rules, they would just need to load and test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean use the loader to "test" in terms of schema validation, but no unit testing explicitly for field validation?
Do we need all the same metadata like rule information if a user wants to directly add schemas to the toml file? |
1c327bd
into
add-configurable-testing-and-validation
Issues
part of elastic/ia-trade-team/issues/258
Summary
Details forthcoming
TODO