Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Typescript Support #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Typescript Support #83

wants to merge 2 commits into from

Conversation

mschorsch
Copy link

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Apr 16, 2020

I generally would prefer to avoid using manually curated .d.ts files. Without additional testing infrastructure it is very very easy for them to get out of sync with reality...

Some suggestions:

  • convert the library to .ts directly (then we know the types are always in sync)
  • add dtslint to our CI setup to ensure things are working properly

@mschorsch mschorsch changed the title Add Type Definitions Add Typescript Support Apr 19, 2020
@mschorsch
Copy link
Author

@rwjblue Thanks for your feedback, i've converted the library to .ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschorsch @rwjblue