Ensure current working directory files do not affect broccoli-funnel operation

[ef4]

A directory in process.cwd() with the same name as the specified srcDir will fake out this line:

broccoli-funnel/index.js

Line 204 in ed9507f

let inputPathExists = this.input.existsSync(this.srcDir || './');

Given the funnel's that Embroider is doing:

new Funnel(someInput, {
  allowEmpty: true,
  srcDir: 'vendor',
  destDir: 'vendor',
});

If you run that code from within a directory that has a vendor folder the check in Funnel linked above (inputPathExists) is true when it should be false.

The real issue is over in https://github.com/SparshithNR/fs-merger/blob/57b5bc5a6131b848fe8bf982261d676cfb85654e/src/index.ts#L66-L102. Working on failing tests over there now.

---

References:

• Failing test demonstrating CWD "bleed through" fs-merger#43
• Refactors to simplify the FS proxy implementation fs-merger#45
• [@embroider/util] Invalid dependency on broccoli-funnel embroider-build/embroider#764
• Update to [email protected] embroider-build/embroider#766

[rwjblue]

OK, I've figured out the root cause. Basically a directory in process.cwd() with the same name as the specified srcDir will fake out this line:

broccoli-funnel/index.js

Line 204 in ed9507f

let inputPathExists = this.input.existsSync(this.srcDir || './');

Given the funnel's that Embroider is doing:

new Funnel(someInput, {
  allowEmpty: true,
  srcDir: 'vendor',
  destDir: 'vendor',
});

If you run that code from within a directory that has a vendor folder the check in Funnel linked above (inputPathExists) is true when it should be false.

The real issue is over in https://github.com/SparshithNR/fs-merger/blob/57b5bc5a6131b848fe8bf982261d676cfb85654e/src/index.ts#L66-L102. Working on failing tests over there now.

[rwjblue]

I've bumped broccoli-plugin to ensure that we have at least [email protected], and the tests pass now.