Correctly compute ConfFCnt for confirmed uplink's downlink MIC #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `ConfFCnt` in the MIC is always one larger then the `FCnt` of the corresponding uplink, as described in brocaar#539. This is because `ctx.DeviceSession.FCntUp` was already incremented by the initial processing of the uplink. Fixes brocaar#539
|
Thanks @abalmos 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ConfFCntin the MIC is always one larger than theFCntof the corresponding uplink, as described in #539. This is becausectx.DeviceSession.FCntUpwas already incremented by the initial processing of the uplink here.I can confirm this PR enables a LoRaWAN v1.1 device to successfully complete ADR.
I did not add a test because I am still trying to understand the framework--this is my first time working with go. I don't see an existing test for v1.1 confirmed uplinks to base it off.
Fixes #539