Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE-340] update rawls model #1725

Merged
merged 2 commits into from
Mar 5, 2025
Merged

Conversation

kevinmarete
Copy link
Contributor

@kevinmarete kevinmarete commented Mar 4, 2025

https://broadworkbench.atlassian.net/browse/CORE-340
Updating rawls model after broadinstitute/rawls#3205

PR checklist

  • For each library you've modified here, decide whether it requires a major, minor, or no version bump. (Click here for guidance)

If you're doing a major or minor version bump to any libraries:

  • Bump the version in project/Settings.scala createVersion()
  • Update CHANGELOG.md for those libraries
  • I promise I used @deprecated instead of deleting code where possible

In all cases:

  • Replace the appropriate version hashes in README.md and the CHANGELOG.md for any libs you changed with TRAVIS-REPLACE-ME to auto-update the version string
  • Get two thumbsworth of PR review
  • Verify all tests go green (CI and coverage tests)
  • Squash commits and merge to develop
  • Delete branch after merge

@kevinmarete kevinmarete requested a review from a team March 4, 2025 21:56
@kevinmarete kevinmarete self-assigned this Mar 4, 2025
@kevinmarete kevinmarete requested review from davidangb and samanehsan and removed request for a team March 4, 2025 21:56
Copy link
Contributor

@davidangb davidangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit inline, else 👍

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.48%. Comparing base (fdb7b18) to head (b7e92ae).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1725   +/-   ##
========================================
  Coverage    24.48%   24.48%           
========================================
  Files          105      105           
  Lines         2745     2745           
  Branches       253      253           
========================================
  Hits           672      672           
  Misses        2073     2073           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinmarete kevinmarete merged commit bfa3066 into develop Mar 5, 2025
3 checks passed
@kevinmarete kevinmarete deleted the km_CORE-340_update_rawls_model branch March 5, 2025 15:41
@kevinmarete kevinmarete restored the km_CORE-340_update_rawls_model branch March 5, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants