report reference genome length in align_reads output; use this value for assemble_refbased. reference_genome_length #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for assemble_refbased. reference_genome_length Currently, assemble_refbased reports reference_genome_length based on inspection of the mapped bam file used in plot_coverage however in the event zero reads map, the reference length is reported as zero. This commit reports the actual length of the sequence in the reference fasta provided to assemble_refbased, as the first Int output of the scattered calls to assembly.align_reads (and exposes the value, which was already obtained but not output, in align_reads)
dpark01
approved these changes
May 7, 2024
|
good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assemble_refbased reports reference_genome_length based on inspection of the mapped bam file used in plot_coverage however in the event zero reads map, the reference length is reported as zero. This commit reports the actual length of the sequence in the reference fasta provided to assemble_refbased, as the first Int output of the scattered calls to assembly.align_reads (and exposes the value, which was already obtained but not output, in align_reads)