Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference selection improvements and nextclade generalization #529

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Mar 28, 2024

  • viral-assemble 2.3.1.3 to 2.3.1.4 -- see release notes for viral-assemble but this changes default parameters to cluster genomes more aggressively and also rank orders hits by ANI * reference bases covered instead of just ANI so as to not favor tiny matches over long ones
  • expose some skani parameters at the WDL task level
  • update nextclade_one_sample to emit more useful (non-empty) output strings for multi-segment viruses like influenza
  • add a taxid_to_nextclade workflow that takes a numeric NCBI taxid and converts it to a nextclade dataset name that can be used as the input value to nextclade_one_sample.dataset_name

@dpark01 dpark01 marked this pull request as ready for review April 3, 2024 23:26
@dpark01 dpark01 merged commit 967ccb9 into master Apr 4, 2024
12 checks passed
@dpark01 dpark01 deleted the dp-scaffold branch April 4, 2024 01:18
@dpark01 dpark01 changed the title WiP refsel improvements Reference selection improvements and nextclade generalization Apr 4, 2024
@@ -188,14 +195,18 @@ task scaffold {
Int replace_length=55
Boolean allow_incomplete_output = false

Int? skani_m
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR we should say more about these single-character params, even if it's only to have entries in the parameter_meta section point to the skani docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants