allow docker image pinning to be skipped with #skip-global-version-pin annotation #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n annotation The script `github_actions_ci/version-wdl-runtimes.sh` is used to replace docker image tags in WDL task files with the tags listed in the `requirements-modules.txt` file. These replacements were previously applied globally. With this commit, image references on lines ending with the comment `#skip-global-version-pin` are exempt from these replacements. This allows tasks to have image versions held back; this is useful in the event that a task has commands that are incompatible with newer image versions.
dpark01
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script
github_actions_ci/version-wdl-runtimes.shis used to replace docker image tags in WDL task files with the tags listed in therequirements-modules.txtfile. These replacements were previously applied globally. With this PR, image references on lines ending with the comment#skip-global-version-pinare exempt from these replacements. This allows tasks to have image versions held back; this is useful in the event that a task has commands that are incompatible with newer image versions.The script
github_actions_ci/check-wdl-runtimes.shalso honors these annotations.The
#skip-global-version-pinannotation is also applied to two tasks which use krakenuniq, as newer versions of the viral-classify image will not provide krakenuniq until an updated conda rebuild exists for the fork https://github.com/yesimon/krakenuniq and its associated dependencies.