-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancing documentation for viral-pipelines #461
Conversation
…eplete and classify_single
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few housekeeping requests -- haven't dug into content yet
.vscode/settings.json
Outdated
@@ -0,0 +1,5 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this file from the branch and perhaps add .vscode/
to the .gitignore
file instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few quick comments
One quick note: I went into readthedocs and activated automatic public builds of the See here for rendered output: https://viral-pipelines.readthedocs.io/en/fnegrete_test/ See here for build status (right now it's succeeding so nothing to see here, but if for some reason you had a syntax error or something, you'd see failures here): https://readthedocs.org/projects/viral-pipelines/builds/ |
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Co-authored-by: Daniel Park <[email protected]>
Did we merge this? Should I keep it open for future documentation fixes? |
amplicon16S analysis wdl renamed to classify_qiime2_multi Noticed that the old name is on the master branch still, so we should updated this |
cateogry: "advanced" | ||
} | ||
min_length: { | ||
description: "Minimum length of the read, cutadapt will discard anything that is shorter than n bp AFTER trimming.Set to default.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whose default? qiime's? cutadapt's? Maybe specify the source of the default and/or its value here. Also maybe specify that it would be reads that would be discarded: "discard anything that is" -> "discard reads that are". If such reads are discarded, does that extend to both reads of a pair for paired-end sequencing, or could it toss one read and keep its mate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this small change, let's get this merged in.
cateogry: "advanced" | ||
} | ||
min_length: { | ||
description: "Minimum length of the read, cutadapt will discard anything that is shorter than n bp AFTER trimming.Set to default.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After this small change, let's get this merged in.
Adding documentation to important input/ouput parameters for some of the more used workflows in the pipeline (assembled_refbased, demux_deplete,classify_single, augur_from_assemblies, and genbank.
Additionally orphan workflows will be noted.