-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parameterize and update defaults for VM shapes in nextstrain tasks #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpark01
changed the title
bump disk sizes in nextstrain
parameterize and update defaults for VM shapes in nextstrain tasks
Mar 2, 2023
These default shape parameters passed on Terra on Azure recently w/latest ncov/open data set |
cjllanwarne
reviewed
Mar 7, 2023
kraefrei
suggested changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, looking through, we did end up doubling all of the disk_sizes for the run
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
kraefrei
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default disk sizes in various nextstrain tasks need to increase to handle the size of ncov/open data. Parameterize most of these values so they can be overridden at runtime by users. Reduce default CPU for mafft (from 96 to 64) to make it easier to run in various clouds. Mostly inspired by some Terra-on-Azure testing.