Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize and update defaults for VM shapes in nextstrain tasks #455

Merged
merged 19 commits into from
Mar 7, 2023

Conversation

dpark01
Copy link
Member

@dpark01 dpark01 commented Feb 24, 2023

Update default disk sizes in various nextstrain tasks need to increase to handle the size of ncov/open data. Parameterize most of these values so they can be overridden at runtime by users. Reduce default CPU for mafft (from 96 to 64) to make it easier to run in various clouds. Mostly inspired by some Terra-on-Azure testing.

@dpark01 dpark01 changed the title bump disk sizes in nextstrain parameterize and update defaults for VM shapes in nextstrain tasks Mar 2, 2023
@dpark01 dpark01 marked this pull request as ready for review March 7, 2023 14:29
@dpark01
Copy link
Member Author

dpark01 commented Mar 7, 2023

These default shape parameters passed on Terra on Azure recently w/latest ncov/open data set

Copy link
Contributor

@kraefrei kraefrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, looking through, we did end up doubling all of the disk_sizes for the run

pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
pipes/WDL/tasks/tasks_nextstrain.wdl Outdated Show resolved Hide resolved
dpark01 and others added 11 commits March 7, 2023 14:42
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
Co-authored-by: Christian Freitas <[email protected]>
@dpark01 dpark01 merged commit 202d952 into master Mar 7, 2023
@dpark01 dpark01 deleted the dp-nextstrain branch March 7, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants