-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set default GPU to K80->P4 in BEAST task; parameterize beagle_order #442
Conversation
pipes/WDL/tasks/tasks_interhost.wdl
Outdated
-beagle_GPU \ | ||
-beagle_cuda \ | ||
-beagle_SSE \ | ||
-beagle_double \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request -- can we parameterize with some boolean beagle_double=true
that turns into either -beagle_double
or -beagle_single
on the command line? In >90% of the xmls I've run, we need double precision to converge well, but every once in a while, single-precision is enough and the speed gains are huge. The best performance/$ is actually on a T4 but only if you're running single-precision.
…er based on GPU count if not otherwise specified expose bool to set single/double precision for beagle; generate+set beagle_order string based on GPU count if not otherwise specified
…ce we don't need to worry about macOS and its quirky BSD interpretation of 'seq' -s
Is this ready to merge? |
Ooh actually this might be a good opportunity to try out / implement some of the thinking in #130. We could:
Cromwell seems to only support one such special file, so we can't do the beast_log too while we're at it. Not sure if the checkpoint file actually contains all the log data as well or if it's only tracking a single state... |
Actually I'll just merge this as-is now and we can work on #130 later. Looking to tag a new release here before the holidays. |
set default GPU to K80->P4 in BEAST task; expose beagle_order as a task input