rework biosample_load to not use todays date in ftp directory path #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biosample_load workflow had been using today's date (ISO format) to construct a target directory path on NCBI's FTP server for BioSample submissions. This is because the directory space on the FTP server never seems to clean up (and we don't have delete permissions) so we need to ensure a unique destination for our inputs.
Using today's date, however, results in cromwell call cache misses of the ftp biosample registration task when sarscov2_illumina_full workflow fail overnight and you need to re-run the next day. This PR removes today's date from the inputs of that task and instead constructs the target directory based on the name of the input tsv file plus its MD5 hash, which should all remain stable for the same inputs.