vm shape bump on downstream nextstrain steps #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite sure what the conditions are that cause this, but recent runs of nextstrain builds seem to require >3GB of RAM at the
ancestral_traitsandtip_frequenciesandexport_auspice_jsontasks. It's a little odd because the size of inputs (# of genomes) should not be increasing at all as the size of GISAID increases, but perhaps these steps have memory growth purely based on metadata table size (even all the irrelevant entries).We could potentially filter the metadata tsv to only the entries selected by the subsampling (and make it an output of the subsample task) so that downstream augur steps only see smaller tables.
Or we could just use more RAM. This PR does the latter.