Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "brand" to "collection" in admin-facing text (SCP-3852) #1283

Merged
merged 3 commits into from
Dec 3, 2021

Conversation

jlchang
Copy link
Contributor

@jlchang jlchang commented Dec 3, 2021

Update two admin-facing locations in the UI where we still use "branding group" instead of "collection".

  1. Under the admin section of the user menu:
    user_menu
  2. The title of the new collection page (which currently only admins see):
    new_collection
    (The other changes requested in the ticket were addressed in SCP-3867 aka Allowing for multiple collection curators, studies in multiple collections (SCP-3849, SCP-3867, SCP-3872) #1265)
    This PR supports SCP-3852.

Copy link
Member

@eweitz eweitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, and I think we're good!

app/views/branding_groups/new.html.erb Outdated Show resolved Hide resolved
Co-authored-by: Eric Weitz <[email protected]>
@jlchang jlchang requested a review from eweitz December 3, 2021 16:17
Copy link
Contributor

@ehanna4 ehanna4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jlchang jlchang added the build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem. label Dec 3, 2021
@jlchang jlchang merged commit 6365780 into development Dec 3, 2021
@jlchang jlchang deleted the jlc_finish_collection_rebrand branch December 3, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure: false positive Build error confirmed as false positive. E.g. upstream service has a problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants