Delete the now redundant ClassFinder #1857
Merged
+3
−191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This has moved to both htsjdk and barclay and is therefore unecessary to have a copy of here. * Downstream users should replace with org.broadinstitute.barclay.argparser.ClassFinder
|
I'm not sure what the picard deprecation policy is / should be? This could be deprecated instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The barclay classfinder is effectively identical and is more likely to be well maintained. There is also a version in htsjdk which should probably be unified somehhow.
See also broadinstitute/barclay#193.