Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore build folder from pip 20.1 #249

Merged
merged 1 commit into from
May 1, 2020
Merged

ignore build folder from pip 20.1 #249

merged 1 commit into from
May 1, 2020

Conversation

StevenSong
Copy link
Collaborator

@StevenSong StevenSong commented May 1, 2020

pip 20.1 came out a few days ago and new docker images use latest pip

pip install now creates a build directory (see changelog "Building of local directories is now done in place" and this issue)

this PR just adds that directory to .gitignore

@StevenSong StevenSong requested a review from paolodi May 1, 2020 20:50
Copy link
Contributor

@paolodi paolodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, @StevieSong !

@StevenSong StevenSong merged commit 16a2ee8 into master May 1, 2020
@StevenSong StevenSong deleted the ss_pip_build branch May 1, 2020 21:17
mklarqvist pushed a commit that referenced this pull request Jun 2, 2020
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
lucidtronix pushed a commit that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants