This repository has been archived by the owner on Jun 4, 2024. It is now read-only.
proposal of changes to how we use sinon #222
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(includes turning on BDC signed URLs for demonstration purposes)
kshakir
approved these changes
May 17, 2021
Comment on lines
+765
to
+768
| const { | ||
| id: objectId, self_uri: drsUri, | ||
| access_methods: { 0: { access_id: accessId, access_url: { url: gsUrl } } } | ||
| } = bdcDrsResponse; |
There was a problem hiding this comment.
NOTE: This destructuring of metadata responses will not work for self_uri from hcaDrsResponse and some others. (Yay "specifications"!) But those tests can be modified to hard code the drsUri some other way.
mcovarr
approved these changes
May 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(includes turning on BDC signed URLs for demonstration purposes)
I can walk through this in person, but here's what I'm thinking we can do with these tests to make them a little more flexible (but still equal coverage) and readable.