Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JN-1486] Referral source + skip pre-enroll + pre-fill pre-enroll [wip] #1280

Draft
wants to merge 5 commits into
base: development
Choose a base branch
from

Conversation

MatthewBemis
Copy link
Member

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

Copy link

sonarcloud bot commented Nov 26, 2024

Copy link
Collaborator

@devonbush devonbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... I'm not sure about adding "referralSource" as a property on Enrollee -- partly because I'm not sure it belongs there, and partly because referral source might get complicated and might be an object, or multiple fields (e.g. referring site + referring person). Think about adding it to PreEnrollmentResponse instead, and have it be either part of the fullData, or a dedicated answer like "qualified"

import { useSearchParams } from 'react-router-dom'
import { Answer } from '@juniper/ui-core'

export function useEnrollmentParams() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great use of hooks

@@ -76,6 +77,7 @@ export default function UserProvider({ children }: { children: React.ReactNode }
const [loginState, setLoginState] = useState<LoginResult | null>(null)
const [isLoading, setIsLoading] = useState(true)
const auth = useAuth()
useEnrollmentParams()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants