Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): allow filtering variant table on ID #309

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

elissa-alarmani
Copy link
Collaborator

@elissa-alarmani elissa-alarmani commented Dec 10, 2024

Fixes #294
Creates a search feature for the variant table that filters by variant ID. Matching text from the search query is then highlighted within the table and the list scrolls to the first matched variant row to maintain context (similar to the gnomAD "display neighboring variants" search feature)
Screenshot 2024-12-10 at 10 40 35 AM

Copy link
Collaborator

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Elissa, thanks for tackling this and nice work getting all the plumbing working.

I left one main comment about keeping the linking functionility working, with a suggestion on how to do that.

There's then one minor suggestion of having padding above the list, see comment inline.

I'm sure Sam will appreciate this search, thanks for following up with this when the change to a fixed sized list inadvertently created the need for this new search, and for following through with the highlighting.

Copy link
Collaborator

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Elissa, codewise and feature wise, this is looking good!

I'm requesting changes to get a bit more rebasing practice, I think (feel free to disagree) a set of two commits here would be appropriate

  • 1 that adds the new dependency
  • 1 that adds the feature to search by variant id with the bar

This way, if any bugs arise, we can more confidently say if it was the dependency commit, or the new commit. Here, just adding an NPM dependency is a bit unlikely to cause problems, but if co-dependencys bump versions or something like that happens, it could cause problems.

I think the practice of keeping bumps to dependencies or tools in isolated commits will pay off in the long run, so I'm just requesting one more interactive rebase to turn this into the two commits proposed above (again, feel free to disagree if you think there should be more or less commits, you'll get a feel for this over time).

Copy link
Collaborator

@rileyhgrant rileyhgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elissa-alarmani elissa-alarmani merged commit 4cf896b into main Dec 19, 2024
1 check passed
@elissa-alarmani elissa-alarmani deleted the ea-search-241119 branch December 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow filtering variant table on ID
2 participants