Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractCohortTest fixups [VS-860] #8274

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Mar 29, 2023

  • Make test public so it can be run within IntelliJ.
  • Make test clean up after itself.

Copy link

@rsasch rsasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcovarr mcovarr force-pushed the vs_860_extract_cohort_test_public branch from 7f8aebc to f968453 Compare March 29, 2023 22:13
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@2dd76f7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 7f8aebc differs from pull request most recent head f968453. Consider uploading reports for the commit f968453 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8274   +/-   ##
================================================
  Coverage                ?   85.874%           
  Complexity              ?     35522           
================================================
  Files                   ?      2194           
  Lines                   ?    167046           
  Branches                ?     18005           
================================================
  Hits                    ?    143449           
  Misses                  ?     17216           
  Partials                ?      6381           

@mcovarr mcovarr merged commit 8217073 into ah_var_store Mar 30, 2023
@mcovarr mcovarr deleted the vs_860_extract_cohort_test_public branch March 30, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants