Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CromwellOnAzure + Azure SQL DB + AAD first steps doc [VS-805] #8191

Merged
merged 11 commits into from
Feb 9, 2023

Conversation

mcovarr
Copy link
Collaborator

@mcovarr mcovarr commented Feb 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@0c48d6d). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2d6c381 differs from pull request most recent head 90d3e3f. Consider uploading reports for the commit 90d3e3f to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##             ah_var_store     #8191   +/-   ##
================================================
  Coverage                ?   84.437%           
  Complexity              ?     34485           
================================================
  Files                   ?      2191           
  Lines                   ?    166339           
  Branches                ?     17901           
================================================
  Hits                    ?    140452           
  Misses                  ?     19452           
  Partials                ?      6435           

Copy link
Collaborator

@gbggrant gbggrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


```
# Fish out the CromwellOnAzure resource group name that was named after your Broad username.
RESOURCE_GROUP=$(az group list | jq -r ".[] | .name | select(test(\"^${USER}-[0-9a-f]+$\"))")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a link to documentation on what on earth a resource group is?

Copy link
Contributor

@RoriCremer RoriCremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my review is definitely colored by the fact that I do not know what a lot of these Azure things are and maybe my questions dont make sense here but I still have them.
Note: I have not run this. Should I?

@mcovarr
Copy link
Collaborator Author

mcovarr commented Feb 9, 2023

Note: I have not run this. Should I?

While I don't think it's absolutely essential at this point I certainly wouldn't discourage it. 😄 Happy to walk through this at mobbing or some other time if you like.

@mcovarr mcovarr force-pushed the vs_805_coa_setup_doc branch from 2d6c381 to 90d3e3f Compare February 9, 2023 19:54
@mcovarr mcovarr merged commit 69ad63b into ah_var_store Feb 9, 2023
@mcovarr mcovarr deleted the vs_805_coa_setup_doc branch February 9, 2023 20:02
koncheto-broad added a commit that referenced this pull request Feb 14, 2023
…into beta workflow (#8200)

* limiting scatter width for beta customers in order to stay under google quotas

* Just moving the beta scatter width to an argument so we can experiment with different numbers (if quotas are increased for a customer) without having to modify our code

* Piping beta information down to GvsImportGenomes

* renaming beta variable to something clearer then rearranging logic to unify the beta and broad use cases better.

* renaming beta variable

* temporarily add it to dockstore

* updating to a newer gatk

* CromwellOnAzure + Azure SQL DB + AAD first steps doc [VS-805] (#8191)

* bits of cleanup

* Don't know why this got yanked in when I rebased

* haste makes waste!

---------

Co-authored-by: Miguel Covarrubias <[email protected]>
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants