Fixing a bug in parsing of T0 tag #8185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyasoifer
force-pushed
the
ilyasoifer/bioin-882-fix.t0.parse.bug
branch
from
5a5cf18 to
1b1e601
Compare
jamesemery
approved these changes
Feb 13, 2023
| if ((probs[qualOfs-1])==(probs[qualOfs])){ | ||
| flowMatrix[1][flowIdx] = Math.max(flowMatrix[1][flowIdx], Math.max(probs[qualOfs-1],probs[qualOfs])); | ||
| } | ||
| flowMatrix[1][flowIdx] = Math.max(flowMatrix[1][flowIdx], Math.min(probs[qualOfs-1],probs[qualOfs])); |
There was a problem hiding this comment.
Can you provide a bit of context as to what the expectation is/was here?
| // instead of actually running the tests. Can be used with "./gradlew test -Dtest.single=HaplotypeCallerIntegrationTest" | ||
| // to update all of the exact-match tests at once. After you do this, you should look at the | ||
| // diffs in the new expected outputs in git to confirm that they are consistent with expectations. | ||
| public static final boolean UPDATE_EXACT_MATCH_EXPECTED_OUTPUTS = false; |
| 322,0,0,.,.,.,.,. 0.9880 | ||
| 322,1,0,.,.,.,.,. 0.0010 | ||
| 322,0,0,.,.,.,.,. 0.8890 | ||
| 322,1,0,.,.,.,.,. 0.1000 |
There was a problem hiding this comment.
These seem like fairly small effects...
There was a problem hiding this comment.
Right. And from the beginning the effect is small. But the fix does seem to improve SNPs a tiny bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.