Rework Hail script generation [VS-616] #8034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
requested review from
RoriCremer,
rsasch,
gbggrant and
koncheto-broad
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## ah_var_store #8034 +/- ##
================================================
Coverage ? 43.628%
Complexity ? 21865
================================================
Files ? 2173
Lines ? 165004
Branches ? 17792
================================================
Hits ? 71988
Misses ? 87583
Partials ? 5433 |
rsasch
approved these changes
Sep 27, 2022
gbggrant
approved these changes
Sep 27, 2022
mcovarr
force-pushed
the
vs_616_split_hail
branch
from
59e32c7 to
71ad359
Compare
RoriCremer
reviewed
Sep 27, 2022
| import hail as hl | ||
|
|
||
| unslashed_tmp_dir = tmp_dir if not tmp_dir.endswith('/') else tmp_dir[:-1] | ||
| hl.init(tmp_dir=f'{unslashed_tmp_dir}/hail_tmp_general') |
RoriCremer
reviewed
Sep 27, 2022
| vqsr_tranche_data=args('vqsr_tranche_data'), | ||
| reference_genome=rg38, | ||
| final_path=vds_output_path, | ||
| tmp_dir=f'{unslashed_tmp_dir}/hail_tmp_import_gvs' |
There was a problem hiding this comment.
this is where we will put:
intermediate_resume_point=x
and also do we want to add:
partitions_per_sample=0.4,
mcovarr
force-pushed
the
vs_616_split_hail
branch
from
2eae410 to
f3dc1fb
Compare
|
Github actions tests reported job failures from actions build 3146642435
|
mcovarr
force-pushed
the
vs_616_split_hail
branch
from
1b7b427 to
926955c
Compare
|
Github actions tests reported job failures from actions build 3153749161
|
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits the original script GVS to Hail import script into two smaller scripts. The first script creates the "MVP" Hail VariantDataset (VDS), the second script implements all further AC/AN/AF and VAT input processing. No Avro file literals are embedded in either script so both scripts are much smaller than the previous single script they replace.
Successful Quickstart run here: https://app.terra.bio/#workspaces/gvs-dev/mlc%20GVS%20Quickstart%20v3/job_history/2e4f192f-1042-4ee5-b1e3-3c00c97e620b
VDS generated from this script: gs://fc-a1621719-20ea-471d-a0ef-a41383dc76bd/submissions/2e4f192f-1042-4ee5-b1e3-3c00c97e620b/GvsExtractAvroFilesForHail/4124ba9e-4220-47f4-af46-8a8f1ba9ca66/call-OutputPath/2022-09-23-74fb33b4/gvs_export.vds
Tieout VCF generated from this VDS: gs://fc-a1621719-20ea-471d-a0ef-a41383dc76bd/submissions/2e4f192f-1042-4ee5-b1e3-3c00c97e620b/GvsExtractAvroFilesForHail/4124ba9e-4220-47f4-af46-8a8f1ba9ca66/call-OutputPath/2022-09-23-74fb33b4/tieout.vcf