VS-222 dont hard code the dataset name! #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
changed the title
RoriCremer
commented
Mar 4, 2022
| @Argument( | ||
| fullName = "dataset-id", | ||
| doc = "ID of the Google Cloud dataset to use when executing queries", | ||
| optional = true // I guess, but wont it break otherwise or require that a dataset be created with the name temp_tables? |
There was a problem hiding this comment.
I'm going to delete this comment, but why is projectId above optional?
rsasch
reviewed
Mar 4, 2022
|
new jar here: gs://broad-dsp-spec-ops/scratch/bigquery-jointcalling/jars/rc_testing_dataset_id_20220303/gatk-package-4.2.0.0-478-g29bb3da-SNAPSHOT-local.jar I suppose I should add it to the WDL as the default |
RoriCremer
force-pushed
the
rc-vs-222-dataset-id
branch
from
23df84d to
4941fc9
Compare
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GvsCreateFilterSet.wdl failed recently for Morgan because of this bug. When run in a brand new project, filter model creation fails because we expect the project to have a hard coded dataset named "temp_tables" which is likely does not have. The workaround is simply to manually create one. This ticket removes the need for this dataset altogether.
This is removed, and instead, the default dataset is used (that the many other tables created in this pipeline use as the default)
able to reproduce with a dummy dataset name:
tested here:
https://app.terra.bio/#workspaces/broad-dsp-spec-ops-fc/gvs_testing_ingest/job_history/1dd27d90-82c4-44e6-8172-15c10c8a9c7f